[Mesa-dev] [PATCH] r600, compute: setup compute sampler states and views

Zoltán Gilián zoltan.gilian at gmail.com
Wed Aug 12 05:16:08 PDT 2015

On 8/11/15, Marek Olšák <maraeo at gmail.com> wrote:
> Do compute sampler states need RADEON_CP_PACKET3_COMPUTE_MODE as well?

Oops, I've forgotten to add it. My mistake.
I'm not sure if needed (I have a working test which uses linear
filtering), but the SET_SAMPLER packet too has a header with the
graphics/compute field, so I think it should be set.

> All changes below should be dropped. All sampler views should be
> referenced here (= increase their refcount). Is there any reason not
> to reference them?

Fair point. Since clover itself allocates/frees the resources, I've
decided not to use the reference counting mechanism. This decision was
made when I hadn't yet added the unset code: at that point clover and
the reference counting interfered and caused memory bugs. So no, there
is no good reason not to reference the sampler views.


More information about the mesa-dev mailing list