[Mesa-dev] [PATCH 1/2] nir: Zero out texture instructions when creating them.

Matt Turner mattst88 at gmail.com
Wed Aug 12 12:37:48 PDT 2015


On Wed, Aug 12, 2015 at 11:55 AM, Eric Anholt <eric at anholt.net> wrote:
> There are so many flags in textures, that the CSE pass would have a hard
> time referencing the correct set when figuring out if two texture ops are
> the same.  By zeroing, we can avoid that fragility.
> ---

Presumably you didn't see that this fixed anything, because
ralloc_size() (which ralloc() wraps) has been mistakenly calling
calloc() since it was added. :)

That's not to say that we shouldn't be zeroing nir_tex_instr anyway.


More information about the mesa-dev mailing list