[Mesa-dev] [PATCH 1/2] mesa: remove extern from texture function

[Brian Paul]

On Thu, Aug 13, 2015 at 2:53 AM, Timothy Arceri <t_arceri at yahoo.com.au>
wrote:

> ---
>  src/mesa/main/teximage.c | 2 +-
>  src/mesa/main/teximage.h | 9 ---------
>  2 files changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
> index fc69387..55cbb37 100644
> --- a/src/mesa/main/teximage.c
> +++ b/src/mesa/main/teximage.c
> @@ -5595,7 +5595,7 @@ check_multisample_target(GLuint dims, GLenum target,
> bool dsa)
>  }
>
>
> -void
> +static void
>  _mesa_texture_image_multisample(struct gl_context *ctx, GLuint dims,
>

You can drop the _mesa_ prefix on static functions.  Looks OK otherwise.
Reviewed-by: Brian Paul <brianp at vmware.com>



>                                  struct gl_texture_object *texObj,
>                                  GLenum target, GLsizei samples,
> diff --git a/src/mesa/main/teximage.h b/src/mesa/main/teximage.h
> index 1eebaa8..bf729da 100644
> --- a/src/mesa/main/teximage.h
> +++ b/src/mesa/main/teximage.h
> @@ -200,15 +200,6 @@ _mesa_copy_texture_sub_image(struct gl_context *ctx,
> GLuint dims,
>                               const char *caller);
>
>  extern void
> -_mesa_texture_image_multisample(struct gl_context *ctx, GLuint dims,
> -                                struct gl_texture_object *texObj,
> -                                GLenum target, GLsizei samples,
> -                                GLint internalformat, GLsizei width,
> -                                GLsizei height, GLsizei depth,
> -                                GLboolean fixedsamplelocations,
> -                                GLboolean immutable, const char *func);
> -
> -extern void
>  _mesa_texture_buffer_range(struct gl_context *ctx,
>                             struct gl_texture_object *texObj,
>                             GLenum internalFormat,
> --
> 2.4.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150813/24fb2b71/attachment.html>