[Mesa-dev] [PATCH 4/4] mesa/formats: refactor by globbing on types in switch statement

[Nanley Chery]

On Fri, Aug 14, 2015 at 4:09 PM, Chad Versace <chad.versace at intel.com>
wrote:

> On Tue 11 Aug 2015, Nanley Chery wrote:
> > From: Nanley Chery <nanley.g.chery at intel.com>
> >
> > Combine the adjacent cases which have the same GL type in the switch
> statemnt.
> >
> > Signed-off-by: Nanley Chery <nanley.g.chery at intel.com>
> > ---
> >  src/mesa/main/formats.c | 152
> ++++++------------------------------------------
> >  1 file changed, 17 insertions(+), 135 deletions(-)
>
> I checked every line in this patch and found no errors.
>
> Patch 4/4 is
> Reviewed-by: Chad Versace <chad.versace at intel.com>
>
> As an aside... Do you think the format's datatype be stored directly in
> the Mesa's format info table? It seems strange that Mesa maintains that
> bit of information outside the info table.
>

Thanks. I do think this is something that should be added to the format
info table. The only downsides I can see are that the csv would increase in
width and that the format info table would take up more memory, but I don't
think that'd be a real problem.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150819/e39c9efc/attachment.html>