[Mesa-dev] [PATCH v2] docs: Update todo regarding StencilOp and StencilOpSeparate.

[Thomas Helland]

2015-08-20 15:03 GMT+02:00 Rhys Kidd <rhyskidd at gmail.com>:
> OpenGL 2.0 function StencilOp() is in part internally implemented via
> StencilOpSeparate(). This change happened some time ago, however the
> accompanying doxygen todo comment was not accordingly updated.
>
> Replace the outdated portion of this doxygen todo comment, leaving the
> remainder unchanged.
>
> Also better respect the 80 character suggested line length in this file.
>
> v2: Fully remove comment, following code review by t_arceri at yahoo.com.au
> Signed-off-by: Rhys Kidd <rhyskidd at gmail.com>
> ---
>  src/mesa/main/stencil.c | 18 ++++++------------
>  1 file changed, 6 insertions(+), 12 deletions(-)
>
> diff --git a/src/mesa/main/stencil.c b/src/mesa/main/stencil.c
> index 2a19a17..409b2f0 100644
> --- a/src/mesa/main/stencil.c
> +++ b/src/mesa/main/stencil.c
> @@ -124,8 +124,8 @@ _mesa_ClearStencil( GLint s )
>   * \sa glStencilFunc().
>   *
>   * Verifies the parameters and updates the respective values in
> - * __struct gl_contextRec::Stencil. On change flushes the vertices and notifies the
> - * driver via the dd_function_table::StencilFunc callback.
> + * __struct gl_contextRec::Stencil. On change flushes the vertices and notifies
> + * the driver via the dd_function_table::StencilFunc callback.
>   */
>  void GLAPIENTRY
>  _mesa_StencilFuncSeparateATI( GLenum frontfunc, GLenum backfunc, GLint ref, GLuint mask )
> @@ -178,8 +178,8 @@ _mesa_StencilFuncSeparateATI( GLenum frontfunc, GLenum backfunc, GLint ref, GLui
>   * \sa glStencilFunc().
>   *
>   * Verifies the parameters and updates the respective values in
> - * __struct gl_contextRec::Stencil. On change flushes the vertices and notifies the
> - * driver via the dd_function_table::StencilFunc callback.
> + * __struct gl_contextRec::Stencil. On change flushes the vertices and notifies
> + * the driver via the dd_function_table::StencilFunc callback.
>   */
>  void GLAPIENTRY
>  _mesa_StencilFunc( GLenum func, GLint ref, GLuint mask )
> @@ -298,8 +298,8 @@ _mesa_StencilMask( GLuint mask )
>   * \sa glStencilOp().
>   *
>   * Verifies the parameters and updates the respective fields in
> - * __struct gl_contextRec::Stencil. On change flushes the vertices and notifies the
> - * driver via the dd_function_table::StencilOp callback.
> + * __struct gl_contextRec::Stencil. On change flushes the vertices and notifies
> + * the driver via the dd_function_table::StencilOp callback.
>   */
>  void GLAPIENTRY
>  _mesa_StencilOp(GLenum fail, GLenum zfail, GLenum zpass)
> @@ -389,12 +389,6 @@ _mesa_ActiveStencilFaceEXT(GLenum face)
>
>
>
> -/**
> - * OpenGL 2.0 function.
> - * \todo Make StencilOp() call this function.  And eventually remove the
> - * ctx->Driver.StencilOp function and use ctx->Driver.StencilOpSeparate
> - * instead.
> - */
>  void GLAPIENTRY
>  _mesa_StencilOpSeparate(GLenum face, GLenum sfail, GLenum zfail, GLenum zpass)
>  {
> --
> 2.1.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev

This patch looks good and is:

Reviewed-by: Thomas Helland <thomashelland90 at gmail.com>

I'll pull it down, add the R-b tag, and temporarily store it 'til I get
a small bunch of reviewed patches. Then I'll send a request to one
of the guys with commit-access, and ask them to commit the bunch.

Thanks a lot for your contribution!

PS: Your last patch series landed a couple days ago.