[Mesa-dev] [PATCH 08/25] glsl: validate binding qualifier for AoA

Ian Romanick idr at freedesktop.org
Thu Aug 20 10:46:17 PDT 2015


I might have been tempted to put this and the previous patch before
patch 6, but meh.

This patch is

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

On 08/19/2015 09:37 PM, Timothy Arceri wrote:
> Reviewed-by: Tapani Pälli <tapani.palli at intel.com>
> ---
>  src/glsl/ast_to_hir.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
> index ee5ff9d..54569a8 100644
> --- a/src/glsl/ast_to_hir.cpp
> +++ b/src/glsl/ast_to_hir.cpp
> @@ -2114,7 +2114,7 @@ validate_binding_qualifier(struct _mesa_glsl_parse_state *state,
>     }
>  
>     const struct gl_context *const ctx = state->ctx;
> -   unsigned elements = type->is_array() ? type->length : 1;
> +   unsigned elements = type->is_array() ? type->arrays_of_arrays_size() : 1;
>     unsigned max_index = qual->binding + elements - 1;
>     const glsl_type *base_type = type->without_array();
>  
> 



More information about the mesa-dev mailing list