[Mesa-dev] [PATCH] glsl: expose textureQueryLod in GLSL 4.00+ fragment shaders

Ilia Mirkin imirkin at alum.mit.edu
Thu Aug 20 11:06:47 PDT 2015

On Thu, Aug 20, 2015 at 2:01 PM, Marek Olšák <maraeo at gmail.com> wrote:
> On Thu, Aug 20, 2015 at 5:15 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>> So just stick something like
>> """
>> From the ARB_texture_query_lod spec:
>>     (3) The core specification uses the "Lod" spelling, not "LOD". Should
>>         this extension be modified to use "Lod"?
>>       RESOLVED: The "Lod" spelling is the correct spelling for the core
>>       specification and the preferred spelling for use. However, use of
>>       "LOD" also exists, as the extension predated the core specification,
>>       so this extension won't remove use of "LOD".
>> """
>> as the commit message? Fine by me. It seems excessive to put that into
>> builtin_functions.cpp... but if people feel strongly, I can do that
>> too.
> People tend to read code more than commit messages, so putting it in
> the code is better.

I don't really see what it adds to either the commit message or the
code... we don't have stuff in the code for like "xyz added by spec
bar". It's pretty obvious from the availability predicate... I don't
see a single other instance of this in builtin_functions.cpp.

More information about the mesa-dev mailing list