[Mesa-dev] vlVaQueryImageFormats and vlVdpVideoSurfaceQueryGetPutBitsYCbCrCapabilities also return unsupported formats

Julien Isorce julien.isorce at gmail.com
Fri Aug 21 09:22:40 PDT 2015


Hi,

vlVaQueryImageFormats (or
vlVdpVideoSurfaceQueryGetPutBitsYCbCrCapabilities) implementation call
pscreen->is_video_format_supported with input profile equal to
PIPE_VIDEO_PROFILE_UNKNOWN.

Problem is that "nouveau_vp3_screen_video_supported" or
"rvid_is_format_supported" will returns several formats: NV12, YV12, YUYV,
UYVY, BGRA because it fallback to call vl_video_buffer_is_format_supported.

Whereas these 2 functions would have return PIPE_FORMAT_NV12 if input
profile is not PIPE_VIDEO_PROFILE_UNKNOWN.

So I wonder if nouveau_vp3_screen_video_supported should just return
PIPE_FORMAT_NV12 in all cases. (same for rvid_is_format_supported)
Am I missing something ?

What is the purpose of checking PIPE_VIDEO_PROFILE_UNKNOWN :
http://cgit.freedesktop.org/mesa/mesa/tree/src/gallium/drivers/nouveau/nouveau_vp3_video.c#n486
and
http://cgit.freedesktop.org/mesa/mesa/tree/src/gallium/drivers/radeon/radeon_video.c#n323
?

Thx
Julien

vaapi spec for vaQueryImageFormats:
http://cgit.freedesktop.org/libva/tree/va/va.h#n2349
vdpau spec for vdpVideoSurfaceQueryGetPutBitsYCbCrCapabilities:
http://cgit.freedesktop.org/~aplattner/libvdpau/tree/include/vdpau/vdpau.h#n1526
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150821/01a93bca/attachment-0001.html>


More information about the mesa-dev mailing list