[Mesa-dev] [PATCH 2/2] i965/nir: Make use of nir_opt_undef

[Thomas Helland]

2015-08-21 15:42 GMT+02:00 Boyan Ding <boyan.j.ding at gmail.com>:
> Shader-db result on Ivy Bridge:
> total instructions in shared programs: 145484 -> 145445 (-0.03%)
> instructions in affected programs:     225 -> 186 (-17.33%)
> helped:                                5
> HURT:                                  0
>

I can report that I get the same amount of shaders helped,
with the same "instructions in affected programs" line as you,
but with a much larger database. Indicates it's the same five
patches from the public shader-db we're seeing changes in.

This patch is:

Reviewed-by: Thomas Helland <thomashelland90 at gmail.com>

I'll pull this down into my branch of patches to be merged,
and get someone to merge it some time in the not to
distant future, if no-one else picks it up first.
(I believe you don't have commit access, right?)

Thanks for your contribution.

> Signed-off-by: Boyan Ding <boyan.j.ding at gmail.com>
> ---
>  src/mesa/drivers/dri/i965/brw_nir.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_nir.c b/src/mesa/drivers/dri/i965/brw_nir.c
> index b5788fa..b59cdc4 100644
> --- a/src/mesa/drivers/dri/i965/brw_nir.c
> +++ b/src/mesa/drivers/dri/i965/brw_nir.c
> @@ -62,6 +62,8 @@ nir_optimize(nir_shader *nir, bool is_scalar)
>        nir_validate_shader(nir);
>        progress |= nir_opt_remove_phis(nir);
>        nir_validate_shader(nir);
> +      progress |= nir_opt_undef(nir);
> +      nir_validate_shader(nir);
>     } while (progress);
>  }
>
> --
> 2.5.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev