[Mesa-dev] [PATCH 01/15] gallium: add an interface for dumping debug driver state

[Brian Paul]

On 08/23/2015 06:04 AM, Marek Olšák wrote:
> From: Marek Olšák <marek.olsak at amd.com>
>
> ---
>   src/gallium/include/pipe/p_context.h | 12 ++++++++++++
>   src/gallium/include/pipe/p_defines.h |  5 +++++
>   2 files changed, 17 insertions(+)
>
> diff --git a/src/gallium/include/pipe/p_context.h b/src/gallium/include/pipe/p_context.h
> index f89dae9..9d8f5bd 100644
> --- a/src/gallium/include/pipe/p_context.h
> +++ b/src/gallium/include/pipe/p_context.h
> @@ -32,6 +32,7 @@
>   #include "p_format.h"
>   #include "p_video_enums.h"
>   #include "p_defines.h"
> +#include <stdio.h>
>
>   #ifdef __cplusplus
>   extern "C" {
> @@ -617,6 +618,17 @@ struct pipe_context {
>       * Return information about unexpected device resets.
>       */
>      enum pipe_reset_status (*get_device_reset_status)(struct pipe_context *ctx);
> +
> +   /**
> +    * Dump driver-specific debug information into a stream. This is
> +    * used by debugging tools.
> +    *
> +    * \param ctx        pipe context
> +    * \param stream     where the output should be written to
> +    * \param flags      a mask of PIPE_DEBUG_* flags
> +    */
> +   void (*dump_debug_state)(struct pipe_context *ctx, FILE *stream,
> +                            unsigned flags);
>   };
>
>
> diff --git a/src/gallium/include/pipe/p_defines.h b/src/gallium/include/pipe/p_defines.h
> index 2ba56ea..4f2aa14 100644
> --- a/src/gallium/include/pipe/p_defines.h
> +++ b/src/gallium/include/pipe/p_defines.h
> @@ -329,6 +329,11 @@ enum pipe_flush_flags
>   };
>
>   /**
> + * Flags for pipe_context::dump_debug_state.
> + */
> +#define PIPE_DEBUG_DEVICE_IS_HUNG      (1 << 0)
> +
> +/**
>    * Flags for pipe_context::memory_barrier.
>    */
>   #define PIPE_BARRIER_MAPPED_BUFFER     (1 << 0)
>

For patches 1 & 2,
Reviewed-by: Brian Paul <brianp at vmware.com>