[Mesa-dev] [PATCH 03/15] gallium/ddebug: new pipe for hang detection and driver state dumping (v2)

[Emil Velikov]

Hi Marek,

On 23 August 2015 at 13:04, Marek Olšák <maraeo at gmail.com> wrote:


> --- /dev/null
> +++ b/src/gallium/drivers/ddebug/Makefile.am
> @@ -0,0 +1,11 @@
> +include Makefile.sources
> +include $(top_srcdir)/src/gallium/Automake.inc
> +
> +AM_CFLAGS = \
> +       $(GALLIUM_DRIVER_CFLAGS)
> +
> +noinst_LTLIBRARIES = libddebug.la
> +
> +libddebug_la_SOURCES = $(C_SOURCES)
> +
> +EXTRA_DIST = SConscript


> --- /dev/null
> +++ b/src/gallium/drivers/ddebug/SConscript
Considering it's not wired up, you can just drop the sconscript build
(and the EXTRA_DIST above)

> diff --git a/src/gallium/drivers/ddebug/dd.h b/src/gallium/drivers/ddebug/dd.h
> new file mode 100644
> index 0000000..c78d112
> --- /dev/null
> +++ b/src/gallium/drivers/ddebug/dd.h
There is already a dd.h file in mesa. So it might be save us some
headaches if we rename this one.

Haven't looked at the symbols provided by dd.h/dd_public.h but I'd
suspect there are no conflicts.

> diff --git a/src/gallium/targets/pipe-loader/Makefile.am b/src/gallium/targets/pipe-loader/Makefile.am
> index 4d9f7be..f18e68c 100644
> --- a/src/gallium/targets/pipe-loader/Makefile.am
> +++ b/src/gallium/targets/pipe-loader/Makefile.am
> @@ -29,6 +29,7 @@ AM_CPPFLAGS = \
>         -I$(top_srcdir)/src/gallium/winsys \
>         $(LIBDRM_CFLAGS) \
>         $(VISIBILITY_CFLAGS) \
> +        -DGALLIUM_DDEBUG \
>         -DGALLIUM_RBUG \
>         -DGALLIUM_TRACE
>
> @@ -55,6 +56,7 @@ PIPE_LIBS += \
>         $(top_builddir)/src/glsl/libnir.la \
>         $(top_builddir)/src/libglsl_util.la \
>         $(top_builddir)/src/util/libmesautil.la \
> +        $(top_builddir)/src/gallium/drivers/ddebug/libddebug.la \
>         $(top_builddir)/src/gallium/drivers/rbug/librbug.la \
>         $(top_builddir)/src/gallium/drivers/trace/libtrace.la \
>         $(GALLIUM_COMMON_LIB_DEPS)
For this to work with the separate pipe-drivers, you need to update
each one (pipe_*.c)

If you want you can do so later on, but if so please drop these
makefile changes.

Thanks
Emil