[Mesa-dev] [PATCH] mesa/formats: pass correct parameter to _mesa_is_format_compressed

[Nanley Chery]

On Tue, Aug 25, 2015 at 5:38 PM, Dave Airlie <airlied at gmail.com> wrote:

> From: Dave Airlie <airlied at redhat.com>
>
> commit 26c549e69d12e44e2e36c09764ce2cceab262a1b
> Author: Nanley Chery <nanley.g.chery at intel.com>
> Date:   Fri Jul 31 10:26:36 2015 -0700
>
>     mesa/formats: remove compressed formats from matching function
>
> caused a regression in my CTS testing, this looks like a clear
> thinko.
>
> sSigned-off-by: Dave Airlie <airlied at redhat.com>
>
You have an extra 's' at the beginning of this line.

> ---
>  src/mesa/main/formats.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/main/formats.c b/src/mesa/main/formats.c
> index 0d88c0b..f217adc 100644
> --- a/src/mesa/main/formats.c
> +++ b/src/mesa/main/formats.c
> @@ -2046,7 +2046,7 @@ _mesa_format_matches_format_and_type(mesa_format
> mesa_format,
>     case MESA_FORMAT_X8R8G8B8_SRGB:
>        return GL_FALSE;
>     default:
> -      assert(_mesa_is_format_compressed(format));
> +      assert(_mesa_is_format_compressed(mesa_format));
>        if (error)
>           *error = GL_INVALID_ENUM;
>     }
> --
> 2.4.3
>
>
Thanks for finding this error! FWIW,

Reviewed-by: Nanley Chery <nanley.g.chery at .intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150825/63bdc990/attachment-0001.html>