[Mesa-dev] [PATCH 07/10] glsl: add support for the imageSamples function
imirkin at alum.mit.edu
Fri Aug 28 09:53:30 PDT 2015
On Fri, Aug 28, 2015 at 12:51 PM, Neil Roberts <neil at linux.intel.com> wrote:
> Ilia Mirkin <imirkin at alum.mit.edu> writes:
>> @@ -2757,6 +2764,11 @@ builtin_builder::add_image_functions(bool glsl)
>> &builtin_builder::_image_size_prototype, 1,
>> flags | IMAGE_FUNCTION_SUPPORTS_FLOAT_DATA_TYPE);
>> + add_image_function(glsl ? "imageSamples" : "__intrinsic_image_samples",
>> + "__intrinsic_image_samples",
>> + &builtin_builder::_image_samples_prototype, 1,
>> + flags | IMAGE_FUNCTION_MS_ONLY);
> I think this needs IMAGE_FUNCTION_SUPPORTS_FLOAT_DATA_TYPE as well.
> Otherwise it won't get a declaration for imageSamples(image2DMS), right?
Yes, I think you're right. I'm going to make some compiler piglits
that test it all to double-check.
More information about the mesa-dev