[Mesa-dev] [PATCH 07/14] gallium/util: fix returning empty box for rectangle intersection
brianp at vmware.com
Fri Aug 28 14:31:26 PDT 2015
From: Roland Scheidegger <sroland at vmware.com>
These functions deal with inclusive coordinates, hence a 0/0/0/0 rect
returned when there's no intersection doesn't actually represent an empty
rectangle. Hence return 0/-1/0/-1 instead.
This fixes some problems in llvmpipe with empty scissor rects (which up
to now didn't really matter because while the intersect test returned the
wrong result all pixels were scissored away later anyway).
src/gallium/auxiliary/util/u_rect.h | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/gallium/auxiliary/util/u_rect.h b/src/gallium/auxiliary/util/u_rect.h
index dea1e1e..221d918 100644
@@ -87,7 +87,12 @@ u_rect_possible_intersection(const struct u_rect *a,
- b->x0 = b->x1 = b->y0 = b->y1 = 0;
+ * Note the u_rect_xx tests deal with inclusive coordinates
+ * hence all-zero would not be an empty box.
+ b->x0 = b->y0 = 0;
+ b->x1 = b->y1 = -1;
More information about the mesa-dev