[Mesa-dev] [PATCH] i965/fs: Use greater-equal cmod to implement maximum.

Matt Turner mattst88 at gmail.com
Mon Aug 31 11:46:28 PDT 2015


On Fri, Aug 28, 2015 at 6:42 PM, Jordan Justen
<jordan.l.justen at intel.com> wrote:
> On 2015-08-28 17:12:31, Matt Turner wrote:
>> See commit 3b7f683f.
>
> That commit message seems short enough to replicate, although it is
> also valuable to mention the hash here too.
>
> Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>

Thanks!

> It almost seems like we could rename emit_minmax to emit_cmpsel,
> optionally make it private, and add emit_min and emit_max.

I like the idea of separate emit_min/emit_max functions (or maybe just
make them macros around emit_minmax).


More information about the mesa-dev mailing list