[Mesa-dev] [PATCH v2 2/2] mesa/texformat: use format conversion function in _mesa_choose_tex_format

[Chad Versace]

On Fri 28 Aug 2015, Nanley Chery wrote:
> I should add that this patch enables this function to handle ASTC formats.
> This in turn enables such formats to be used for GL calls such as
> Tex*Storage*.
> 
> - Nanley
> 
> On Wed, Aug 26, 2015 at 2:38 PM, Nanley Chery <nanleychery at gmail.com> wrote:
> 
> > From: Nanley Chery <nanley.g.chery at intel.com>
> >
> > This function's cases for non-generic compressed formats duplicate
> > the GL to MESA translation in _mesa_glenum_to_compressed_format().
> > This patch replaces the switch cases with a call to the translation
> > function.
> >
> > Cc: Brian Paul <brianp at vmware.com>
> > Cc: Chad Versace <chad.versace at intel.com>
> > Cc: Ian Romanick <ian.d.romanick at intel.com>
> > Signed-off-by: Nanley Chery <nanley.g.chery at intel.com>
> > ---
> >  src/mesa/main/texformat.c | 94
> > +++++++----------------------------------------
> >  1 file changed, 13 insertions(+), 81 deletions(-)

This patch looks good to me. Please comment in the commit message that
this change teaches the function about ASTC, thus enabling ASTC for
glTex*Storage*() calls. And then this patch will be
Reviewed-by: Chad Versace <chad.versace at intel.com>