[Mesa-dev] [PATCH v3] mesa: enable enums for OES_geometry_shader

Ilia Mirkin imirkin at alum.mit.edu
Tue Dec 1 08:33:56 PST 2015

On Tue, Dec 1, 2015 at 11:24 AM, Lofstedt, Marta
<marta.lofstedt at intel.com> wrote:
>> > +static const int extra_ARB_viewport_array_or_geometry_shader[] = {
>> > +   EXT(ARB_viewport_array),
>> > +   EXT(OES_geometry_shader),
>> > +   EXTRA_END
>> > +};
>> This won't do what you want... unless drivers only ever set
>> OES_geometry_shader to true in ES contexts, which is not the way it's usually
>> done in mesa. That said they *are* careful about only setting
>> ARB_viewport_array in core contexts (due to the GS dependency).
> I am now confused about what you really want here.
> Do you want me to only check these enums for oes_geometry_shader?
> We have the same situation for gpu_shader5, right?

As always, what I really want is for it to work :) Any way you choose
to achieve that is fine by me. As it stands, I could have a situation
where ARB_viewport_array = false, OES_geometry_shader = true, and I'm
in a desktop GL 3.2 core context, and now all of a sudden that
extra_ARB_viewport_array_or_geometry_shader thing is true. But... you
don't want it to be.


More information about the mesa-dev mailing list