[Mesa-dev] [PATCH 1/2] configure.ac: Refuse to build with Sun C compiler.

[Alan Coopersmith]

On 12/ 2/15 01:04 AM, Roland Mainz wrote:
> On Wed, Dec 2, 2015 at 12:38 AM, Alan Coopersmith
> <alan.coopersmith at oracle.com> wrote:
>> On 12/ 1/15 03:07 PM, Jose Fonseca wrote:
>>>
>>> https://bugs.freedesktop.org/show_bug.cgi?id=93189
>>> ---
>>>    configure.ac | 7 +++++++
>>>    1 file changed, 7 insertions(+)
>>>
>>> diff --git a/configure.ac b/configure.ac
>>> index 4016871..b6680d0 100644
>>> --- a/configure.ac
>>> +++ b/configure.ac
>>> @@ -197,6 +197,13 @@ if test "x$GCC" = xyes -a "x$acv_mesa_CLANG" = xno;
>>> then
>>>        fi
>>>    fi
>>>
>>> +dnl We don't support building Mesa with Sun C compiler
>>> +dnl https://bugs.freedesktop.org/show_bug.cgi?id=93189
>>> +AC_CHECK_DECL([__SUNPRO_C], [SUNCC=yes], [SUNCC=no])
>>> +if test "x$SUNCC" = xyes; then
>>> +    AC_MSG_ERROR([Building with Sun C compiler is not supported, use GCC
>>> instead.])
>>> +fi
>>> +
>>>    dnl Check for compiler builtins
>>>    AX_GCC_BUILTIN([__builtin_bswap32])
>>>    AX_GCC_BUILTIN([__builtin_bswap64])
>>>
>>
>> Acked-by: Alan Coopersmith <alan.coopersmith at oracle.com>
>
> Just curious: Why ?

Because Mesa developers continue to use extensions & syntax that Studio does
not support, and no one is putting in the effort to rewrite the Mesa code to
work with Studio and still be maintainable by people without Studio access.
We've built Mesa for Solaris with gcc for a while, so this won't impact us,
and no one else seems to want Studio support enough to make it work.

There's a half dozen bugs in the Mesa bugzilla for non-portable code that
breaks on Studio that have been filed recently that this closes.

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc