[Mesa-dev] [PATCH v3 14/44] i965: Add debug flag to print out the new L3 state during transitions.

[Kenneth Graunke]

On Tuesday, December 01, 2015 12:19:32 AM Jordan Justen wrote:
> From: Francisco Jerez <currojerez at riseup.net>
> 
> Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>
> Reviewed-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com>
> ---
>  src/mesa/drivers/dri/i965/gen7_l3_state.c | 17 +++++++++++++++++
>  src/mesa/drivers/dri/i965/intel_debug.c   |  1 +
>  src/mesa/drivers/dri/i965/intel_debug.h   |  1 +
>  3 files changed, 19 insertions(+)
> 
> diff --git a/src/mesa/drivers/dri/i965/gen7_l3_state.c b/src/mesa/drivers/dri/i965/gen7_l3_state.c
> index a895723..b3b5b2e 100644
> --- a/src/mesa/drivers/dri/i965/gen7_l3_state.c
> +++ b/src/mesa/drivers/dri/i965/gen7_l3_state.c
> @@ -456,6 +456,18 @@ update_urb_size(struct brw_context *brw, const struct brw_l3_config *cfg)
>     }
>  }
>  
> +/**
> + * Print out the specified L3 configuration.
> + */
> +static void
> +dump_l3_config(const struct brw_l3_config *cfg)
> +{
> +   fprintf(stderr, "SLM=%d URB=%d ALL=%d DC=%d RO=%d IS=%d C=%d T=%d\n",
> +           cfg->n[L3P_SLM], cfg->n[L3P_URB], cfg->n[L3P_ALL],
> +           cfg->n[L3P_DC], cfg->n[L3P_RO],
> +           cfg->n[L3P_IS], cfg->n[L3P_C], cfg->n[L3P_T]);
> +}
> +
>  static void
>  emit_l3_state(struct brw_context *brw)
>  {
> @@ -485,6 +497,11 @@ emit_l3_state(struct brw_context *brw)
>        setup_l3_config(brw, cfg);
>        update_urb_size(brw, cfg);
>        brw->l3.config = cfg;
> +
> +      if (unlikely(INTEL_DEBUG & DEBUG_L3)) {
> +         fprintf(stderr, "L3 config transition (%f > %f): ", dw, dw_threshold);
> +         dump_l3_config(cfg);
> +      }
>     }
>  }
>  
> diff --git a/src/mesa/drivers/dri/i965/intel_debug.c b/src/mesa/drivers/dri/i965/intel_debug.c
> index d073d66..e08c296 100644
> --- a/src/mesa/drivers/dri/i965/intel_debug.c
> +++ b/src/mesa/drivers/dri/i965/intel_debug.c
> @@ -78,6 +78,7 @@ static const struct debug_control debug_control[] = {
>     { "tcs",         DEBUG_TCS },
>     { "ds",          DEBUG_TES },
>     { "tes",         DEBUG_TES },
> +   { "l3",          DEBUG_L3 },
>     { NULL,    0 }
>  };
>  
> diff --git a/src/mesa/drivers/dri/i965/intel_debug.h b/src/mesa/drivers/dri/i965/intel_debug.h
> index 175ac68..b7b5111 100644
> --- a/src/mesa/drivers/dri/i965/intel_debug.h
> +++ b/src/mesa/drivers/dri/i965/intel_debug.h
> @@ -71,6 +71,7 @@ extern uint64_t INTEL_DEBUG;
>  #define DEBUG_NO_COMPACTION       (1ull << 35)
>  #define DEBUG_TCS                 (1ull << 36)
>  #define DEBUG_TES                 (1ull << 37)
> +#define DEBUG_L3                  (1ull << 38)
>  
>  #ifdef HAVE_ANDROID_PLATFORM
>  #define LOG_TAG "INTEL-MESA"
> 

Good call, this will be really nice to have as a debug flag.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20151203/c3a827ff/attachment.sig>