[Mesa-dev] [PATCH 0/2] Remove _mesa_is_array_texture

Alejandro Piñeiro apinheiro at igalia.com
Sat Dec 5 10:47:22 PST 2015

Recently I realized that there are two methods that provides the
same functionality, _mesa_is_array_texture (at teximage.[ch]) and
_mesa_tex_target_is_array (at texformat.[ch]) so it makes sense
to remove one.

This two-patch series removes _mesa_is_array_texture just because
_mesa_tex_target_is_array is older. But it is worth to note that
perhaps some people would prefer the other way, because teximage.h
already have other utility methods like this (example: _mesa_is_proxy_texture)
and because _mesa_is_array_texture has a more proper returning value
based on this review:
So although if someone prefers to keep the newer instead of the older,
I can make the opposite change.

Alejandro Piñeiro (2):
  i965: use _mesa_tex_target_is_array instead of _mesa_is_array_texture
  mesa: remove _mesa_is_array_texture

 src/mesa/drivers/dri/i965/gen7_wm_surface_state.c |  2 +-
 src/mesa/drivers/dri/i965/gen8_surface_state.c    |  2 +-
 src/mesa/main/teximage.c                          | 23 -----------------------
 src/mesa/main/teximage.h                          |  3 ---
 4 files changed, 2 insertions(+), 28 deletions(-)


More information about the mesa-dev mailing list