[Mesa-dev] [PATCH 2/3] freedreno: change to goto fail

Serge Martin edb+mesa at sigluy.net
Sun Dec 6 06:32:16 PST 2015


in fd_resource_transfer_map, like the others error cases
---
 src/gallium/drivers/freedreno/freedreno_resource.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/gallium/drivers/freedreno/freedreno_resource.c b/src/gallium/drivers/freedreno/freedreno_resource.c
index 63ca9e3..bcdd518 100644
--- a/src/gallium/drivers/freedreno/freedreno_resource.c
+++ b/src/gallium/drivers/freedreno/freedreno_resource.c
@@ -337,10 +337,8 @@ fd_resource_transfer_map(struct pipe_context *pctx,
 	}
 
 	buf = fd_bo_map(rsc->bo);
-	if (!buf) {
-		fd_resource_transfer_unmap(pctx, ptrans);
-		return NULL;
-	}
+	if (!buf)
+		goto fail;
 
 	offset = slice->offset +
 		box->y / util_format_get_blockheight(format) * ptrans->stride +
-- 
2.1.0



More information about the mesa-dev mailing list