[Mesa-dev] [PATCH v2 1/2] i965: use _mesa_is_array_texture instead of _mesa_tex_target_is_array

Alejandro Piñeiro apinheiro at igalia.com
Mon Dec 7 11:29:25 PST 2015



On 07/12/15 17:00, Brian Paul wrote:
> On 12/05/2015 12:51 PM, Alejandro Piñeiro wrote:
>> Both methods provide the same functionality, so one would be
>> removed.
>>
>> v2: use _mesa_is_array_texture and not the other way (Brian Paul)
>> ---
>>   src/mesa/drivers/dri/i965/gen7_wm_surface_state.c | 2 +-
>>   src/mesa/drivers/dri/i965/gen8_surface_state.c    | 2 +-
>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/mesa/drivers/dri/i965/gen7_wm_surface_state.c
>> b/src/mesa/drivers/dri/i965/gen7_wm_surface_state.c
>> index 2aa395b..7918256 100644
>> --- a/src/mesa/drivers/dri/i965/gen7_wm_surface_state.c
>> +++ b/src/mesa/drivers/dri/i965/gen7_wm_surface_state.c
>> @@ -500,7 +500,7 @@ gen7_update_renderbuffer_surface(struct
>> brw_context *brw,
>>         /* fallthrough */
>>      default:
>>         surftype = translate_tex_target(gl_target);
>> -      is_array = _mesa_tex_target_is_array(gl_target);
>> +      is_array = _mesa_is_array_texture(gl_target);
>>         break;
>>      }
>>
>> diff --git a/src/mesa/drivers/dri/i965/gen8_surface_state.c
>> b/src/mesa/drivers/dri/i965/gen8_surface_state.c
>> index 80252a5..85e1285 100644
>> --- a/src/mesa/drivers/dri/i965/gen8_surface_state.c
>> +++ b/src/mesa/drivers/dri/i965/gen8_surface_state.c
>> @@ -452,7 +452,7 @@ gen8_update_renderbuffer_surface(struct
>> brw_context *brw,
>>         /* fallthrough */
>>      default:
>>         surf_type = translate_tex_target(gl_target);
>> -      is_array = _mesa_tex_target_is_array(gl_target);
>> +      is_array = _mesa_is_array_texture(gl_target);
>>         break;
>>      }
>>
>>
>
> For both,
> Reviewed-by: Brian Paul <brianp at vmware.com>

Thank you.

>
> Do you need someone to push these for you?

No, I can't push them myself. Thanks in any case.

BR

-- 
Alejandro Piñeiro (apinheiro at igalia.com)



More information about the mesa-dev mailing list