[Mesa-dev] [PATCH 1/7] i965/vec4: Use byte offsets for UBO pulls on Sandy Bridge

Jason Ekstrand jason at jlekstrand.net
Mon Dec 7 21:55:21 PST 2015


On Mon, Dec 7, 2015 at 5:18 PM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> On Monday, December 07, 2015 04:52:21 PM Jason Ekstrand wrote:
>> Previously, the VS_OPCODE_PULL_CONSTANT_LOAD opcode operated on
>> vec4-aligned byte offsets on Iron Lake and below and worked in terms of
>> vec4 offsets on Sandy Bridge.  On Ivy Bridge, we add a new *LOAD_GEN7
>> variant which works in terms of vec4s.  We're about to change the GEN7
>> version to work in terms of bytes, so this is a nice unification.
>> ---
>>  src/mesa/drivers/dri/i965/brw_vec4_generator.cpp | 17 +++++++++++++++--
>>  src/mesa/drivers/dri/i965/brw_vec4_nir.cpp       | 18 +++++++++++++-----
>>  src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp   |  6 +++---
>>  3 files changed, 31 insertions(+), 10 deletions(-)
>
> Patches 1-6 are:
> Cc: "11.0" <mesa-stable at lists.freedesktop.org>

I didn't put the CC on patch 6 since it's really prep-work for patch 7

Emil,
I tagged these for 11.0, but they may not apply.  They should at least
go in 11.1
--Jason

> Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
>
> with the bug number fixed in patch 3 and
> s/comps_per_component/comps_per_unit/ in the subject of patch 6.


More information about the mesa-dev mailing list