[Mesa-dev] [PATCH v3 03/12] nir: Get rid of *_indirect variants of input/output load/store intrinsics

Jason Ekstrand jason at jlekstrand.net
Tue Dec 8 15:52:21 PST 2015


On Tue, Dec 8, 2015 at 2:47 PM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> On Tuesday, December 08, 2015 01:46:20 PM Jason Ekstrand wrote:
> [snip]
>> @@ -461,8 +455,7 @@ print_intrinsic_instr(nir_intrinsic_instr *instr, print_state *state)
>>     }
>>
>>     nir_foreach_variable(var, var_list) {
>> -      if ((var->data.driver_location == instr->const_index[0]) &&
>> -          var->name) {
>> +      if ((var->data.driver_location == instr->const_index[0]) && var->name) {
>>           fprintf(fp, "\t/* %s */", var->name);
>>           break;
>>        }
>>
>
> This last hunk seems unrelated - perhaps it should be a separate patch?
> That patch would get a R-b.

FIxed locally.  Thanks!


More information about the mesa-dev mailing list