[Mesa-dev] [Mesa-stable] [PATCH] i965: Fix crash when calling glViewport with no surface bound

Neil Roberts neil at linux.intel.com
Wed Dec 9 06:57:55 PST 2015


Emil Velikov <emil.l.velikov at gmail.com> writes:

> Worth throwing in 11.0 as well ?

Yeah, that would probably be sensible.

>>     if (_mesa_is_winsys_fbo(ctx->DrawBuffer)) {
>> -      dri2InvalidateDrawable(driContext->driDrawablePriv);
>> -      dri2InvalidateDrawable(driContext->driReadablePriv);
>> +      if (driContext->driDrawablePriv)
>> +         dri2InvalidateDrawable(driContext->driDrawablePriv);
>> +      if (driContext->driReadablePriv)
>> +         dri2InvalidateDrawable(driContext->driReadablePriv);
>
>  Afaict i915 could use an identical fix ?

Yes, I think you're right. However I don't have any way of testing it so
I feel a bit uncomfortable touching i915 driver.

Regards,
- Neil


More information about the mesa-dev mailing list