[Mesa-dev] [PATCH 1/2] r600: fix viewport clipping magic.

[Marek Olšák]

I have to NAK this series, but I was able to find something about the issue.

If oViewport is used, VGT_REUSE_OFF must disable reuse. That's the correct fix.

If oViewport is constant, reuse can be enabled, but
VTE_VPORT_PROVOKE_DISABLE must be set.

Marek

On Fri, Dec 11, 2015 at 3:11 AM, Dave Airlie <airlied at gmail.com> wrote:
> From: Dave Airlie <airlied at redhat.com>
>
> This fixes the CTS ARB_viewport_array tests and the
> arb_viewport_array-render-viewport-2 test I sent to the piglit list.
>
> I'm not sure what this register does, or if we should ever not
> be setting it, but lets just set it always for now.
>
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  src/gallium/drivers/r600/r600_state_common.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/r600/r600_state_common.c b/src/gallium/drivers/r600/r600_state_common.c
> index 6a66634..993a438 100644
> --- a/src/gallium/drivers/r600/r600_state_common.c
> +++ b/src/gallium/drivers/r600/r600_state_common.c
> @@ -1652,7 +1652,8 @@ void r600_emit_clip_misc_state(struct r600_context *rctx, struct r600_atom *atom
>         radeon_set_context_reg(cs, R_028810_PA_CL_CLIP_CNTL,
>                                state->pa_cl_clip_cntl |
>                                (state->clip_dist_write ? 0 : state->clip_plane_enable & 0x3F) |
> -                               S_028810_CLIP_DISABLE(state->clip_disable));
> +                               S_028810_CLIP_DISABLE(state->clip_disable) |
> +                              S_028810_VTE_VPORT_PROVOKE_DISABLE(1));
>         radeon_set_context_reg(cs, R_02881C_PA_CL_VS_OUT_CNTL,
>                                state->pa_cl_vs_out_cntl |
>                                (state->clip_plane_enable & state->clip_dist_write));
> --
> 2.5.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev