[Mesa-dev] [PATCH 14/26] i965: Add Gen8+ tessellation evaluation shader state (3DSTATE_DS).

[Kenneth Graunke]

On Wednesday, December 09, 2015 01:40:37 PM Jordan Justen wrote:
> On 2015-12-02 16:15:55, Kenneth Graunke wrote:
[snip]
> > +      OUT_BATCH(GEN7_DS_ENABLE |
> > +                GEN7_DS_STATISTICS_ENABLE |
> > +                (brw->max_ds_threads - 1) << HSW_DS_MAX_THREADS_SHIFT |
> 
> SET_FIELD?
> 
> Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>

We could.  I'd rather not for Gen7, at least, because the mask is 6:0 on
IVB and 7:0 on HSW...which means I'd need two different SET_FIELD calls.
Plus, it's a brw_device_info constant which is guaranteed to fit, so the
extra assert doesn't buy us a lot.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20151211/7d2c592d/attachment.sig>