[Mesa-dev] [PATCH] i965: Move brw_cs_fill_local_id_payload() to libi965_compiler

Matt Turner mattst88 at gmail.com
Fri Dec 11 11:58:41 PST 2015


On Fri, Dec 11, 2015 at 11:22 AM, Kristian Høgsberg Kristensen
<krh at bitplanet.net> wrote:
> This is a helper function for setting up the local invocation ID
> payload according to the cs_prog_data generated by the compiler. It's
> intended to be available to users of libi965_compiler so move it there.

I moved this to brw_cs.c (from brw_fs.cpp) in commit 6ba700c because
its lack of extern "C" decoration on the function definition caused
undefined references when I cleaned up the #includes. I didn't
particularly like moving C code into C++ files willy-nilly, and it's
because of problems like that, and really -- when it's a C function
and is only called from C, why are we making it C++...?

Can we find a better spot than this, and we can stop undoing each
others' patches? :)


More information about the mesa-dev mailing list