[Mesa-dev] [PATCH v2 03/13] nir: Add a writemask to store intrinsics.

[Kenneth Graunke]

On Saturday, December 12, 2015 02:01:49 PM Jason Ekstrand wrote:
> On Sat, Dec 12, 2015 at 2:00 PM, Jason Ekstrand <jason at jlekstrand.net> wrote:
> > On Sat, Dec 12, 2015 at 12:22 PM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> >> On Saturday, December 12, 2015 08:29:37 AM Jason Ekstrand wrote:
> >>> On Dec 11, 2015 1:24 PM, "Kenneth Graunke" <kenneth at whitecape.org> wrote:
> >>> >  /* src[] = { value, offset }. const_index[] = { base, write_mask } */
> >>> >  STORE(shared, 2, 1, 0)
> >>
> >> While we're here, this comment seems wrong, doesn't it?  There's only
> >> one index, but the comment lists two.  (It's wrong before my patch...)
> >
> > Yes, we should fix that.  It's only one index.  That was my mistake
> > while rebasing on shared variables.
> 
> Scratch taht.  This is correct.  When doing shared variables, I
> decided to go with base+offset since they are also opaque.  That was
> intentional.

Then the code is wrong, not the comment... :(
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20151212/f11c7bf8/attachment-0001.sig>