[Mesa-dev] [PATCH 1/5] nv50, nvc0: fix using uninitialized value 'templ.texture' in nvXX_blit_set_src()

[Ilia Mirkin]

While true, this isn't a real issue.

   view->pipe = *templ;
   view->pipe.reference.count = 1;
   view->pipe.texture = NULL;

texture can be uninitialized in the template. I know that your first
impulse might be "just make Coverity happy", but I don't pander to
broken tools. If the report is bogus, mark it bogus, don't add
bogosity to the code.

  -ilia


On Mon, Dec 14, 2015 at 5:14 AM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
> Field 'templ.texture' is used uninitialized when calling
> nvXX_create_texture_view(). Spotted by Coverity.
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/gallium/drivers/nouveau/nv50/nv50_surface.c | 1 +
>  src/gallium/drivers/nouveau/nvc0/nvc0_surface.c | 1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/src/gallium/drivers/nouveau/nv50/nv50_surface.c b/src/gallium/drivers/nouveau/nv50/nv50_surface.c
> index 86be1b4..b03e893 100644
> --- a/src/gallium/drivers/nouveau/nv50/nv50_surface.c
> +++ b/src/gallium/drivers/nouveau/nv50/nv50_surface.c
> @@ -1031,6 +1031,7 @@ nv50_blit_set_src(struct nv50_blitctx *blit,
>
>     target = nv50_blit_reinterpret_pipe_texture_target(res->target);
>
> +   templ.texture = NULL;
>     templ.format = format;
>     templ.u.tex.first_level = templ.u.tex.last_level = level;
>     templ.u.tex.first_layer = templ.u.tex.last_layer = layer;
> diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_surface.c b/src/gallium/drivers/nouveau/nvc0/nvc0_surface.c
> index f8e1efb..41fb82a 100644
> --- a/src/gallium/drivers/nouveau/nvc0/nvc0_surface.c
> +++ b/src/gallium/drivers/nouveau/nvc0/nvc0_surface.c
> @@ -841,6 +841,7 @@ nvc0_blit_set_src(struct nvc0_blitctx *ctx,
>
>     target = nv50_blit_reinterpret_pipe_texture_target(res->target);
>
> +   templ.texture = NULL;
>     templ.format = format;
>     templ.u.tex.first_layer = templ.u.tex.last_layer = layer;
>     templ.u.tex.first_level = templ.u.tex.last_level = level;
> --
> 2.6.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev