[Mesa-dev] [PATCH 5/5] nouveau: remove logically dead code in nouveau_vpe_mb_mv_header()

[Samuel Pitoiset]

On 12/14/2015 04:48 PM, Pierre Moreau wrote:
> On 11:14 AM - Dec 14 2015, Samuel Pitoiset wrote:
>> frame cannot be NULL in that branch. Spotted by Coverity.
>>
>> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
>> ---
>>   src/gallium/drivers/nouveau/nouveau_video.c | 2 --
>>   1 file changed, 2 deletions(-)
>>
>> diff --git a/src/gallium/drivers/nouveau/nouveau_video.c b/src/gallium/drivers/nouveau/nouveau_video.c
>> index 8bb12b2..fe19bce 100644
>> --- a/src/gallium/drivers/nouveau/nouveau_video.c
>> +++ b/src/gallium/drivers/nouveau/nouveau_video.c
>> @@ -317,8 +317,6 @@ nouveau_vpe_mb_mv_header(struct nouveau_decoder *dec,
>>         case PIPE_MPEG12_MO_TYPE_16x8: goto mv2;
>>         case PIPE_MPEG12_MO_TYPE_DUAL_PRIME: {
>>         base = NV17_MPEG_CMD_CHROMA_MV_HEADER_MV_SPLIT_HALF_MB;
>> -         if (frame)
>> -            base |= NV17_MPEG_CMD_CHROMA_MV_HEADER_TYPE_FRAME;
>
> If frame can't be NULL, shouldn't you only remove the `if` statement as you're
> otherwise removing used code as well?

Wrong commit message... frame is *always* NULL in that branch...

>
>
> Pierre
>
>
>>            if (forward)
>>               nouveau_vpe_mb_mv(dec, base, luma, frame, true,
>>                                 dec->picture_structure != PIPE_MPEG12_PICTURE_STRUCTURE_FIELD_TOP,
>> --
>> 2.6.4
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/mesa-dev

-- 
-Samuel