[Mesa-dev] [PATCH 1/6] gallium: Remove unnecessary semicolons

[Emil Velikov]

On 14 December 2015 at 18:11, Brian Paul <brianp at vmware.com> wrote:
> On 12/14/2015 09:27 AM, Edward O'Callaghan wrote:

>> --- a/src/gallium/auxiliary/util/u_surface.c
>> +++ b/src/gallium/auxiliary/util/u_surface.c
>> @@ -600,7 +600,7 @@ is_box_inside_resource(const struct pipe_resource
>> *res,
>>         depth = res->array_size;
>>         assert(res->array_size % 6 == 0);
>>         break;
>> -   case PIPE_MAX_TEXTURE_TYPES:;
>> +   case PIPE_MAX_TEXTURE_TYPES:
>>      }
>>
>>      return box->x >= 0 &&
>
>
> That semicolon is needed for MSVC (at least).  You'll get a "syntax error:
> missing ';' before '}'" error otherwise.
>
Just a drive-by comment, feel free to discard :-)

One could even throw in a "break;" to make static analysis tools happy
(haven't checked if they complain as is).

-Emil