[Mesa-dev] [PATCH 3/3] i965: Use MESA_FORMAT_B8G8R8X8_SRGB for RGB visuals

[Jason Ekstrand]

On Dec 13, 2015 2:06 PM, "Mike Lothian" <mike at fireburn.co.uk> wrote:
>
> Hi
>
> These three commits have stopped Plasma5's kwin  working on my skylake
system

As another data point, it also breaks XWayland+DRI3 on my BDW. I can't even
run glsgears without it segfaulting.

> Reverting back to 7752bbc44e78e982de3cd4c34862adc38a338234 fixed it for me
>
> I can send you more details / raise a bug if you like
>
> Cheers
>
> Mike
>
> On Sat, 12 Dec 2015 at 20:56 Kenneth Graunke <kenneth at whitecape.org>
wrote:
>>
>> On Friday, December 11, 2015 12:32:18 PM Neil Roberts wrote:
>> > Previously if the visual didn't have an alpha channel then it would
>> > pick a format that is not sRGB-capable. I don't think there's any
>> > reason not to always have an sRGB-capable visual. Since 28090b30 there
>> > are now visuals advertised without an alpha channel which means that
>> > games that don't request alpha bits in the config would end up without
>> > an sRGB-capable visual. This was breaking supertuxkart which assumes
>> > the winsys buffer is always sRGB-capable.
>> >
>> > The previous code always used an RGBA format if the visual config
>> > itself was marked as sRGB-capable regardless of whether the visual has
>> > alpha bits. I think we don't actually advertise any sRGB-capable
>> > visuals (but we just use sRGB formats anyway) so it shouldn't make any
>> > difference. However this patch also changes it to use RGBX if an
>> > sRGB-capable visual is requested without alpha bits for consistency.
>> >
>> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92759
>> > Cc: "11.0 11.1" <mesa-stable at lists.freedesktop.org>
>> > Cc: Ilia Mirkin <imirkin at alum.mit.edu>
>> > Suggested-by: Ilia Mirkin <imirkin at alum.mit.edu>
>> > ---
>> >  src/mesa/drivers/dri/i965/intel_screen.c | 13 ++++++-------
>> >  1 file changed, 6 insertions(+), 7 deletions(-)
>>
>> The whole series is:
>> Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
>>
>> We definitely should have the same behavior regardless of whether the
>> config has an alpha channel.  So, this is good.
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20151214/c409020e/attachment-0001.html>