[Mesa-dev] [PATCH 2/8] st/va: cleanup filter color standard handling

[Christian König]

On 15.12.2015 11:06, Emil Velikov wrote:
> On 11 December 2015 at 12:33, Christian König <deathsimple at vodafone.de> wrote:
>> From: Christian König <christian.koenig at amd.com>
>>
>> Signed-off-by: Christian König <christian.koenig at amd.com>
>> ---
>>   src/gallium/state_trackers/va/surface.c | 8 ++++----
>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/src/gallium/state_trackers/va/surface.c b/src/gallium/state_trackers/va/surface.c
>> index c052c8f..4a18a6f 100644
>> --- a/src/gallium/state_trackers/va/surface.c
>> +++ b/src/gallium/state_trackers/va/surface.c
>> @@ -697,11 +697,11 @@ vlVaQueryVideoProcFilterCaps(VADriverContextP ctx, VAContextID context,
>>      return VA_STATUS_SUCCESS;
>>   }
>>
>> -static VAProcColorStandardType vpp_input_color_standards[VAProcColorStandardCount] = {
>> +static VAProcColorStandardType vpp_input_color_standards[] = {
>>      VAProcColorStandardBT601
>>   };
>>
>> -static VAProcColorStandardType vpp_output_color_standards[VAProcColorStandardCount] = {
>> +static VAProcColorStandardType vpp_output_color_standards[] = {
>>      VAProcColorStandardBT601
>>   };
>>
> I was going to suggest to constifying them while we're here, yet it
> seems that the VAAPI will just discard them. The whole API seems to
> have only a few const qualifiers :-(

Making variables const when the API discards it will produce a compiler 
warning.

I'm also not sure if it is really allowed to have those members point to 
const structures or if they need to be allocated on the heap.

VAAPI in general seems to lack a lot of stuff that I would expect from a 
well defined API, e.g. from designing it defensively over good 
documentation to the mess that's MPEG4 part 2 support.

I already thought about suggesting to gb and a couple of others if they 
don't want to start over with it.

Regards,
Christian.

>
> Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>
>
> -Emil