[Mesa-dev] [PATCH 8/8] st/va: add BOB/WEAVE deinterlacing

[Emil Velikov]

On 11 December 2015 at 12:33, Christian König <deathsimple at vodafone.de> wrote:
> From: Christian König <christian.koenig at amd.com>
>
> Tested with MPV.
>
Since this patch does not add WEAVE support (since it's used by the
state tracker by default) can we add a small note about it. Any shape
or form will be great.

> Signed-off-by: Christian König <christian.koenig at amd.com>
> ---
>  src/gallium/state_trackers/va/postproc.c | 72 ++++++++++++++++++++++++++++----
>  src/gallium/state_trackers/va/surface.c  | 16 ++++++-
>  2 files changed, 78 insertions(+), 10 deletions(-)
>
> diff --git a/src/gallium/state_trackers/va/postproc.c b/src/gallium/state_trackers/va/postproc.c
> index c6cfd3a..bcac66a 100644
> --- a/src/gallium/state_trackers/va/postproc.c
> +++ b/src/gallium/state_trackers/va/postproc.c
> @@ -51,7 +51,8 @@ vlVaPostProcCompositor(vlVaDriver *drv, vlVaContext *context,
>                         const VARectangle *src_region,
>                         const VARectangle *dst_region,
>                         struct pipe_video_buffer *src,
> -                       struct pipe_video_buffer *dst)
> +                       struct pipe_video_buffer *dst,
> +                       enum vl_compositor_deinterlace deinterlace)
Why introduce the unused argument ?

With this said, it seems that we don't seem to support (implement) BOB
for non NV12 formats. Should we add a message somewhere - runtime,
in-code, at the top of the patch, or just go more extreme ?

-Emil