[Mesa-dev] [PATCH 4/5] i965: Enable compute shaders in more cases for OpenGLES 3.1

[Jordan Justen]

On 2015-12-15 17:00:55, Ian Romanick wrote:
> Doesn't this make patch 3 irrelevant?  FWIW, I like this better.

This change only updates the way we program some constants. It is for
a local stage_exists array, which we then use later in the same
function when programming context constants.

For example, without this change, I don't think image_load_store has
any images to work with for the compute stage.

-Jordan

> 
> On 12/15/2015 04:08 PM, Jordan Justen wrote:
> > Previously we were checking the desktop OpenGL ARB_compute_shader
> > requirements, but for OpenGLES 3.1, the requirements are lower.
> > 
> > Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
> > Cc: Marta Lofstedt <marta.lofstedt at intel.com>
> > ---
> >  src/mesa/drivers/dri/i965/brw_context.c | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c
> > index 0abe601..5105625 100644
> > --- a/src/mesa/drivers/dri/i965/brw_context.c
> > +++ b/src/mesa/drivers/dri/i965/brw_context.c
> > @@ -377,7 +377,10 @@ brw_initialize_context_constants(struct brw_context *brw)
> >        [MESA_SHADER_GEOMETRY] = brw->gen >= 6,
> >        [MESA_SHADER_FRAGMENT] = true,
> >        [MESA_SHADER_COMPUTE] =
> > -         (ctx->Const.MaxComputeWorkGroupSize[0] >= 1024) ||
> > +         (ctx->API == API_OPENGL_CORE &&
> > +          ctx->Const.MaxComputeWorkGroupSize[0] >= 1024) ||
> > +         (ctx->API == API_OPENGLES2 &&
> > +          ctx->Const.MaxComputeWorkGroupSize[0] >= 128) ||
> >           _mesa_extension_override_enables.ARB_compute_shader,
> >     };
> >  
> > 
>