[Mesa-dev] [Libva] [PATCH] st/va: retrieve size from the temporary img variable

[Christian König]

Yeah, agree reviewing them on the mesa list is probably more appropriate.

Anyway patch lgtm as well and is Reviewed-by: Christian König 
<christian.koenig at amd.com>

Regards,
Christian.

On 15.12.2015 18:53, Julien Isorce wrote:
> + mesa-dev of course :)
>
> Thx Sean
>
> On 15 December 2015 at 17:46, Sean V Kelley <seanvk at posteo.de 
> <mailto:seanvk at posteo.de>> wrote:
>
>
>     > On Dec 15, 2015, at 1:01 AM, Julien Isorce
>     <julien.isorce at gmail.com <mailto:julien.isorce at gmail.com>> wrote:
>     >
>     > "image" is not ready yet since it will be set at
>     > the end of the function by: *image = *img;
>     >
>     > Signed-off-by: Julien Isorce <j.isorce at samsung.com
>     <mailto:j.isorce at samsung.com>>
>     > ---
>     > src/gallium/state_trackers/va/image.c | 2 +-
>     > 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
>     lgtm but you should also add mesa list for this particular patch…
>
>     Sean
>
>     >
>     > diff --git a/src/gallium/state_trackers/va/image.c
>     b/src/gallium/state_trackers/va/image.c
>     > index 58c9ff7..ccc263f 100644
>     > --- a/src/gallium/state_trackers/va/image.c
>     > +++ b/src/gallium/state_trackers/va/image.c
>     > @@ -264,7 +264,7 @@ vlVaDeriveImage(VADriverContextP ctx,
>     VASurfaceID surface, VAImage *image)
>     >    img->image_id = handle_table_add(drv->htab, img);
>     >
>     >    img_buf->type = VAImageBufferType;
>     > -   img_buf->size = image->data_size;
>     > +   img_buf->size = img->data_size;
>     >    img_buf->num_elements = 1;
>     >
>     > pipe_resource_reference(&img_buf->derived_surface.resource,
>     surfaces[0]->texture);
>     > --
>     > 1.9.1
>     >
>     > _______________________________________________
>     > Libva mailing list
>     > Libva at lists.freedesktop.org <mailto:Libva at lists.freedesktop.org>
>     > http://lists.freedesktop.org/mailman/listinfo/libva
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20151216/163ee9e4/attachment.html>