[Mesa-dev] [PATCH v5 4/4] build: enable st/va with nouveau driver

[Ilia Mirkin]

On Wed, Dec 16, 2015 at 9:40 AM, Julien Isorce <j.isorce at samsung.com> wrote:
> vainfo fails in vaDriverInit because "dd_create_screen"
> does not reach strcmp(driver_name, "nouveau") code.
> Indeed when compiling the va target.c, the macro GALLIUM_NOUVEAU
> is not defined.
> This patch define the macro the same it is done for dri and
> vdpau targets.
>
> Tested with:
> ./autogen.sh --enable-glx --enable-gles2 --enable-egl --enable-vdpau --enable-glx-tls=yes --enable-va
> --with-gallium-drivers=swrast,nouveau --with-dri-drivers=swrast,nouveau --with-egl-platforms=x11
>
> LIBVA_DRIVER_NAME=gallium vainfo
> Output:
> vainfo: Driver version: mesa gallium vaapi
> vainfo: Supported profile and entrypoints
>       VAProfileMPEG2Simple            : VAEntrypointVLD
>       VAProfileMPEG2Main              : VAEntrypointVLD
>       VAProfileMPEG4Simple            : VAEntrypointVLD
>       VAProfileMPEG4AdvancedSimple    : VAEntrypointVLD
>       VAProfileVC1Simple              : VAEntrypointVLD
>       VAProfileVC1Main                : VAEntrypointVLD
>       VAProfileVC1Advanced            : VAEntrypointVLD
>       VAProfileH264Baseline           : VAEntrypointVLD
>       VAProfileH264Main               : VAEntrypointVLD
>       VAProfileH264High               : VAEntrypointVLD
>
> Signed-off-by: Julien Isorce <j.isorce at samsung.com>
> ---
>  src/gallium/targets/va/Makefile.am | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/src/gallium/targets/va/Makefile.am b/src/gallium/targets/va/Makefile.am
> index 733e7ac..1edd5c2 100644
> --- a/src/gallium/targets/va/Makefile.am
> +++ b/src/gallium/targets/va/Makefile.am
> @@ -42,6 +42,8 @@ TARGET_DRIVERS =
>  TARGET_CPPFLAGS =
>  TARGET_LIB_DEPS =
>
> +include $(top_srcdir)/src/gallium/drivers/nouveau/Automake.inc
> +

No need for this newline... otherwise Reviewed-by: Ilia Mirkin
<imirkin at alum.mit.edu>

However that's of little good without working out the rest of the series :)

>  include $(top_srcdir)/src/gallium/drivers/r600/Automake.inc
>  include $(top_srcdir)/src/gallium/drivers/radeonsi/Automake.inc
>
> --
> 1.9.1
>