[Mesa-dev] [PATCH v3 3/3] mesa: add SSBOs to the list of fragment shader side effects

Iago Toral Quiroga itoral at igalia.com
Fri Dec 18 01:18:01 PST 2015

The i965 driver uses this function to decide if it can disable the
FS unit in the absence of color/depth writes. We don't want to disable
the unit in the presence of SSBOs, since the fragment shader could
be writing to it.

We could go a step further and check not just for the presence of SSBOs
but also if the shader code writes to them. Does not look worth the trouble
though and we are not doing this for atomic buffers either anyway.

v2: put this into a generic _mesa_active_fragment_shader_has_side_effects
    function instead of having one specific for SSBOs (Jason).

Fixes the following CTS test:
 src/mesa/main/mtypes.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h
index 834ba59..1eafc5d 100644
--- a/src/mesa/main/mtypes.h
+++ b/src/mesa/main/mtypes.h
@@ -4551,7 +4551,9 @@ _mesa_active_fragment_shader_has_side_effects(const struct gl_context *ctx)
       return false;
    sh = ctx->Shader._CurrentFragmentProgram->_LinkedShaders[MESA_SHADER_FRAGMENT];
-   return sh->NumAtomicBuffers > 0 || sh->NumImages > 0;
+   return sh->NumAtomicBuffers > 0 ||
+          sh->NumImages > 0 ||
+          sh->NumShaderStorageBlocks > 0;
 #ifdef __cplusplus

More information about the mesa-dev mailing list