[Mesa-dev] [PATCH] gallium/radeon: only dispose locally created target machine in radeon_llvm_compile

Michel Dänzer michel at daenzer.net
Sun Dec 20 19:03:04 PST 2015

On 19.12.2015 02:15, Nicolai Hähnle wrote:
> On 17.12.2015 22:13, Michel Dänzer wrote:
>> On 18.12.2015 07:00, Nicolai Hähnle wrote:
>>> From: Nicolai Hähnle <nicolai.haehnle at amd.com>
>>> Unify the cleanup paths of the function rather than duplicating code.
>> This should probably be backported to the stable branches? If so, add
> True. It's not like it's a critical fix, given that it affects an error
> path anyway, but hey :)

Well, it does mean that if LLVMTargetMachineEmitToMemoryBuffer fails for
any reason, we'll probably crash the next time around, because we'll
still try to use sctx->tm which has been disposed of?

Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer

More information about the mesa-dev mailing list