[Mesa-dev] [PATCH 1/9] st/va: make the implementation thread save

[Julien Isorce]

On 21 December 2015 at 15:10, Christian König <deathsimple at vodafone.de>
wrote:

> On 21.12.2015 11:05, Andy Furniss wrote:
>
>> Julien Isorce wrote:
>>
>>> Hi Christian,
>>>
>>> I have 2 remarks:
>>>
>>> 1: I am sure you have the clear answer to the following questions, so
>>> maybe add a comment in the commit message: Isn't the thread safety
>>> delegated to the application that use vaapi ? like it is designed for
>>> many libraries. I tried to find answer in vaapi-intel-driver and
>>> libva but it is not obvious. I'll try the mailing list. For vdpau you
>>> are right: "All VDPAU functionality is fully thread-safe; any number
>>> of threads may call into any VDPAU functions at any time. VDPAU may
>>> not be called from signal-handlers." I could not find something
>>> equivalent for vaapi but I guess it would make sense if it was the
>>> same.
>>>
>>
>> Oh, interesting as ffmpeg recently decided hwdec should be forced to
>> single thread for some reason. It hurts perf for using ffmpeg cli.
>>
>
> Well I had to add this because of the simple reason MPV failed miserable
> in some circumstances because it assumed that VA-API is thread safe.
>
> And yes Julien your suspicion is right that VA-API simply doesn't define
> this properly like VDPAU does.
>

I guess you saw the conversation on libva mailing list, what you did
matches what it is done in intel-vaapi-driver so that's great.

I had time to go further, the series is:
Reviewed-by: Julien Isorce <j.isorce at samsung.com>
Tested-by: Julien Isorce <j.isorce at samsung.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20151222/e86cb9fb/attachment.html>