[Mesa-dev] [PATCH v2 11/12] nir: Add return lowering pass

[Connor Abbott]

On Mon, Dec 28, 2015 at 5:02 PM, Jason Ekstrand <jason at jlekstrand.net> wrote:
>
>
> On Mon, Dec 28, 2015 at 1:28 PM, Connor Abbott <cwabbott0 at gmail.com> wrote:
>>
>> On Mon, Dec 28, 2015 at 4:21 PM, Jason Ekstrand <jason at jlekstrand.net>
>> wrote:
>> >>
>> >>
>> >> but I hope you can get loops working soon so you can test this (and
>> >> hey, loops are useful for other things too :P).
>> >
>> >
>> > Yeah, I'm starting on adding a real CFG to spirv_to_nir today.  It's the
>> > task that I've had on my todo list for a long time that I've been
>> > avoiding
>> > and hoping would go away.  It didn't go away.
>> > --Jason
>> >
>>
>> What do you mean by this? I thought I had gotten everything working
>> except for structured continue and switches... what's broken about
>> loops now?
>
>
> The fact that glslang is now almost always generating continues?  Also, I
> don't think we can do switches without some sort of CFG data structure.

Oh, we need to handle it even if there aren't any continues in the
source shader? That's too bad... and yeah, I guess we'll need
something more sophisticated for switches.