[Mesa-dev] [PATCH 7/9] nir: Fix broken fsat recognizer.
cwabbott0 at gmail.com
Sun Feb 1 15:59:12 PST 2015
On Sun, Feb 1, 2015 at 6:54 PM, Eric Anholt <eric at anholt.net> wrote:
> Connor Abbott <cwabbott0 at gmail.com> writes:
>> On Sun, Feb 1, 2015 at 4:17 PM, Eric Anholt <eric at anholt.net> wrote:
>>> We've probably never seen this ridiculous pattern in the wild, so it
>>> didn't matter.
>> I don't think this pattern is 'ridiculous' at all -- GLSL doesn't have
>> a sat operation, so shaders wanting to do a saturate have to do this
>> already. Rather, what probably saves us is that we already recognize
>> this pattern in GLSL IR. Other than that,
>> Reviewed-by: Connor Abbott <cwabbott0 at gmail.com>
> I meant "we hadn't seen that this was a bug because nobody would clamp
> the wrong way around like this."
Ah, I see.
More information about the mesa-dev