[Mesa-dev] [PATCH v5 2/3] i965/fs: Use NIR's scalarizing abilities and stop handling vectors

[Kenneth Graunke]

On Thursday, January 29, 2015 01:40:19 PM Jason Ekstrand wrote:
> Now that we can scalarize with NIR, there's no need for all this code
> anymore.  Let's get rid of it and just do scalar operations.
> 
> v2: run copy prop before lowering phi nodes
> 
> v3: Get rid of the "emit(...)->saturate = foo" pattern
> 
> total instructions in shared programs: 5998321 -> 5974070 (-0.40%)
> instructions in affected programs:     732075 -> 707824 (-3.31%)
> helped:                                3137
> HURT:                                  191
> GAINED:                                18
> LOST:                                  0
> ---
>  src/mesa/drivers/dri/i965/brw_fs.h       |  15 -
>  src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 476 ++++++++++---------------------
>  2 files changed, 153 insertions(+), 338 deletions(-)
> 

It looks like you have two separate case...case runs that result in:

   unreachable("Lowered by nir_lower_alu_reductions");

It might make sense to combine them into one big group.  (Not worth
sending a v4, just do that before pushing, if you like the suggestion.)

As is, this is:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150202/4e90855e/attachment.sig>