[Mesa-dev] [PATCH] util: move etc shared code to util library

[Kai Wasserbäch]

Dave Airlie wrote on 03.02.2015 05:48:
> From: Dave Airlie <airlied at redhat.com>
> 
> Like the RGTC code sharing this could be done nicer in the util lib.
> 
> This slighty increase i965_dri.so size by ~100 bytes,
> but it decreases the combined gallium driver by over 1k,
> and its just nicer to avoid TAG().
> 
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  src/gallium/auxiliary/util/u_format_etc.c |  22 ++--
>  src/mesa/Makefile.sources                 |   1 -
>  src/mesa/main/texcompress_etc.c           |  32 +++---
>  src/mesa/main/texcompress_etc_tmp.h       | 170 ------------------------------
>  src/util/Makefile.sources                 |   2 +
>  src/util/format_etc.c                     | 136 ++++++++++++++++++++++++
>  src/util/format_etc.h                     |  78 ++++++++++++++
>  7 files changed, 237 insertions(+), 204 deletions(-)
>  delete mode 100644 src/mesa/main/texcompress_etc_tmp.h
>  create mode 100644 src/util/format_etc.c
>  create mode 100644 src/util/format_etc.h
> 
> [...]
> diff --git a/src/util/format_etc.c b/src/util/format_etc.c
> new file mode 100644
> index 0000000..5676bbf
> --- /dev/null
> +++ b/src/util/format_etc.c
> @@ -0,0 +1,136 @@
> +/*
> + [...]
> +
> +#include "format_etc.h"
> +#define MIN2( A, B )   ( (A)<(B) ? (A) : (B) )


Shouldn't macros.h be included instead of defining MIN2 again?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 630 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150203/4dc7fd13/attachment.sig>