[Mesa-dev] [PATCH 3/3] i965: Remove now unnecessary Gen8 CMP destination type override.

Matt Turner mattst88 at gmail.com
Tue Feb 3 22:17:38 PST 2015


---
 src/mesa/drivers/dri/i965/brw_eu_emit.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_eu_emit.c b/src/mesa/drivers/dri/i965/brw_eu_emit.c
index 57161e2..308b305 100644
--- a/src/mesa/drivers/dri/i965/brw_eu_emit.c
+++ b/src/mesa/drivers/dri/i965/brw_eu_emit.c
@@ -1849,14 +1849,6 @@ void brw_CMP(struct brw_compile *p,
    struct brw_context *brw = p->brw;
    brw_inst *insn = next_insn(p, BRW_OPCODE_CMP);
 
-   if (brw->gen >= 8) {
-      /* The CMP instruction appears to behave erratically for floating point
-       * sources unless the destination type is also float.  Overriding it to
-       * match src0 makes it work in all cases.
-       */
-      dest.type = src0.type;
-   }
-
    brw_inst_set_cond_modifier(brw, insn, conditional);
    brw_set_dest(p, insn, dest);
    brw_set_src0(p, insn, src0);
-- 
2.0.4



More information about the mesa-dev mailing list