[Mesa-dev] Rename mesa/src/util (Was: gallium/util: add u_bit_scan64)

Brian Paul brianp at vmware.com
Wed Feb 4 08:42:24 PST 2015


On 02/04/2015 07:04 AM, Jose Fonseca wrote:
> This change broke MinGW/MSVC builds because ffsll is not available there.
>
>
> There is a ffsll C fallback, but it's in src/mesa/main/imports.[ch].  So
> rather than duplicating it in src/gallium/auxiliary/util/u_math.h I'd
> prefer move it to src/util.
>
>
> And here lies the problem: what header name should be used for math
> helpers?
>
>
> I think the filenames in src/util and the directory itself is poorly
> named for something that is meant to be included by some many other
> components:
> - there is no unique prefix in most headers
> - util/ clashes with src/gallium/auxiliary/util/
>
>
> Hence I'd like to propose to:
>
> - rename src/util to something unique (e.g, cgrt, for Common Graphics
> RunTime
>
> And maybe:
>
> - prefix all header/source files in there with a cgrt_* unique prefix too
>
> And maybe in the future
>
> - use cgrt_* prefix for symbols too.
>


Actually, I've been wondering for a while now why we don't just use 
Gallium's utility code in Mesa for stuff like this.  It's pretty well 
sorted out there already.

-Brian



More information about the mesa-dev mailing list