[Mesa-dev] [PATCH 3/7] glsl: Add initial functions to implement an on-disk cache
mattst88 at gmail.com
Wed Feb 4 18:10:40 PST 2015
On Wed, Feb 4, 2015 at 6:04 PM, Carl Worth <cworth at cworth.org> wrote:
> On Wed, Feb 04 2015, Matt Turner wrote:
>> Rebase needed. I removed GLSL_SRCDIR a week and a half ago.
> Was this the removal of all those subdir-objects warnings? Thank you!
Yes! Just one warning remaining :).
>> I don't think it makes a difference to autotools, but I think I'd list
>> cache.h here instead of in LIBGLSL_FILES.
> Actually, that was sort of intentional. The cache.c file is only conditionally
> compiled, but cache.h has the inline stub implementations that we want
> to compile unconditionally. So it felt right to put the .h in the
> unconditional list.
> Of course, maybe that doesn't matter at all. It's the .c files that
> include the .h file that are going to result in the inline stubs being
> provided. Now that we're on the subject, what does automake even
> do with .h files that are listed in these lists? Do they need to be
> there for non-srcdir builds to work or something?
It's just used to tell the `dist` rule to include it in the tarball.
> If it truly doesn't matter, then I would prefer to see the cache.h next
> to the cache.c, yes.
Yeah, I don't think it matters. I think make itself figures out
dependencies on headers.
More information about the mesa-dev