[Mesa-dev] [PATCH 01/10] i965/cfg: Allow cfg::dump to be called without a visitor.

Matt Turner mattst88 at gmail.com
Wed Feb 4 20:21:18 PST 2015


The fs_visitor's dump_instruction() implementation calls cfg_t()
indirectly through calculate_live_intervals, so if you have an infinite
loop in the CFG code, you can't call cfg::dump(fs_visitor *) to debug
it.
---
 src/mesa/drivers/dri/i965/brw_cfg.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/mesa/drivers/dri/i965/brw_cfg.cpp b/src/mesa/drivers/dri/i965/brw_cfg.cpp
index 62cc239..ca5b01c 100644
--- a/src/mesa/drivers/dri/i965/brw_cfg.cpp
+++ b/src/mesa/drivers/dri/i965/brw_cfg.cpp
@@ -418,7 +418,8 @@ cfg_t::dump(backend_visitor *v) const
                  link->block->num);
       }
       fprintf(stderr, "\n");
-      block->dump(v);
+      if (v != NULL)
+         block->dump(v);
       fprintf(stderr, "END B%d", block->num);
       foreach_list_typed(bblock_link, link, link, &block->children) {
          fprintf(stderr, " ->B%d",
-- 
2.0.4



More information about the mesa-dev mailing list