[Mesa-dev] [PATCH 3/7] glsl: Add initial functions to implement an on-disk cache

Carl Worth cworth at cworth.org
Thu Feb 5 10:44:21 PST 2015

On Wed, Feb 04 2015, Tapani Pälli wrote:
> What would you think about changing this to use some defined maximum 
> size (in MB)? I think for the user size is what matters and it could be 
> a configurable option, number of items seems a bit vague and hard to 
> predict (?)

Yes, changing over to a maximum size would provide a nice, configurable
knob for the user.

I don't see an easy way to get the current "index file" approach to
allow for size-based management. But the index file is also the only
piece of code that's still got some FIXME comments in it that I'm not
sure how to best address.

I think I'll call the index file a premature optimization and just pull
it out. That will make the initial patch provide a cache of unlimited
size (no replacement at all). Then, I'll follow up with a patch that
provides some sort of size-based replacement policy.

> Will there be some further verification here if the file contents are 
> what is expected or is this done in higher level where cache is
> called?

I would expect any verification to take place at a higher level.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150205/9f1c9d14/attachment.sig>

More information about the mesa-dev mailing list